[INT-177] Remove username from user #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed a preview of this PR to https://pr-140-internal.dev.ystv.co.uk |
markspolakovs
approved these changes
Sep 4, 2024
| @@ -25,7 +25,6 @@ export default async function AuthenticatedLayout({ | |||
|
|
|||
| Sentry.setUser({ | |||
| id: user.user_id, | |||
| username: user.username, | |||
There was a problem hiding this comment.
Just double-check in the Sentry docs that it isn't required, then go ahead and merge
archessmn
deleted the
int-177-sign-in-fails-if-your-emails-prefix-matches-another-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user
usernamefield is unique, causing user creation to fail if the email prefix (anything before the "@") is used by another user. This made sense when only allowing google login from@york.ac.ukbut causes issues now that login with slack is also available. The username field is unused everywhere except for Sentry, where it is used alongside the email it is derived from, and so is not needed.